PHPStan Fixes

[erikn69]

No description provided.

[willpower232]

This is looking good, thanks for fixing them. Definitely covered the ones I couldn't get round my head but apparently now it is sad about the config

 ------ ---------------------------------------------------------------------------------------------------------- 
  Line   config/audit.php                                                                                          
 ------ ---------------------------------------------------------------------------------------------------------- 
  5      Called 'env' outside of the config directory which returns null when the config is cached, use 'config'.  
         🪪  larastan.noEnvCallsOutsideOfConfig                                                                    
 ------ ---------------------------------------------------------------------------------------------------------- 

Is it worth starting a new branch for v14 which can include larastan 3.0 and drop PHP 7 etc? Then we could have a phpstan.neon config file which this error could be ignored in.

[willpower232]

I also wonder if it would be worth locking in to specific versions of phpstan and larastan so that random new errors don't crop up all the time.

[erikn69]

Called 'env' outside of the config directory

I think I'll fix that by uploading the phpstan action

I also wonder if it would be worth locking in to specific versions of phpstan and larastan so that random new errors don't crop up all the time.

I was thinking of keeping it in action and always using the latest version, what do you think?
I want to avoid increasing the maintenance load

[willpower232]

phpstan is really good at adding more checks every new version so if it wasn't locked at a particular version, new PRs would end up triggering errors in code they hadn't changed.

Obviously we can't have a composer.lock file so I think the best way would be having the specific version number without the ^ in composer.json and then it would work exactly the same locally as it does in actions

[erikn69]

Whatever, this PR does not add any github action, nor does it change the composer.json
The discussion would not be here