Fix m_requestHostName variable behavior #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocessConnection()
|
marcstern
approved these changes
Nov 12, 2024
|
No other notes, going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR fixes the wrong behavior of
m_requestHostNametransaction variable.why
Previously, this variable was set when the
setRequestHostName()was called, but previously it was initialized inprocessConnection(). So the last function overwritten the variable, and the previously set value disappeared.If the connector calls if after
processConnection(), then thehostfield in log entries which generated duringprocessConnection()phase does not contain the necessary value.The solution was to add a condition which sets the
m_requestHostNameonly if it's empty. Also the correct call to the functionsetRequestHostName()can be seen in theregression.cc.This modification does not modify the API.