Port miniserve to async #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovstinga
commented
Dec 20, 2024
| pub trait Handler: Fn(Request) -> Response + Send + Sync + 'static {} | ||
| pub trait Handler: Fn(Request) -> Self::Future + Send + Sync + 'static { | ||
| type Future: Future<Output = Response> + Send + Sync + 'static; | ||
| } |
There was a problem hiding this comment.
Take a close look at the change to the Handler trait. Previously, a handler was a function that took a request and returned a response. Now, a handler is a function that takes a request and returns a future which eventually returns a response.
ovstinga
commented
Dec 20, 2024
| pub fn run(self) { | ||
| let listener = | ||
| TcpListener::bind("127.0.0.1:3000").expect("Failed to connect to 127.0.0.1:3000"); | ||
| pub async fn run(self) { |
There was a problem hiding this comment.
Note that the run function is now asynchronous, indicated by the async keyword.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
miniserveAPI to use Rust's async features via Tokio. Unfortunately, this breaks theservercrate, so CI is failing.