docs: add warning to adding new MFEs section of the README about the MFE plugin URL ending in .git #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
requested changes
Jan 9, 2024
changelog.d/20240109_111904_fateme.khodayari97_update_readme_of_custom_mfe_plugin_url.md
Outdated
Show resolved
Hide resolved
regisb
requested changes
Jan 12, 2024
…the MFE plugin URL ending in .git
FatemeKhodayari
force-pushed
the
FatemeKhodayari/update-readme-of-custom-mfe-plugin-url
branch
from
c29808b to
c1fac12
Compare
FatemeKhodayari
deleted the
FatemeKhodayari/update-readme-of-custom-mfe-plugin-url
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Tutor v17 (Quince release) custom MFE plugins only accept URLs ending in
.git. Providing a normal URL of the repository will cause failure in the build of MFE image when runningtutor images build mfeas the custom MFE won't get cloned.This issue was previously mentioned in this topic and the changelog was updated in this PR. This PR updates the readme.
Closes #180