Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document mfe patches catalog #177

Merged
merged 3 commits into from
Dec 18, 2023
Merged

docs: document mfe patches catalog #177

merged 3 commits into from
Dec 18, 2023

Conversation

Danyal-Faheem
Copy link
Contributor

Changes

  • Added a catalog which includes every patch available for tutor-mfe in the README.
  • Also included a one liner description of each patch for users to understand.

Fixes this issue.

@regisb regisb requested a review from arbrandes December 12, 2023 08:38
regisb
regisb requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent work! I only have a few minor comments.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
changelog.d/20231212_131405_danyal.faheem_document_mfe_patches_catalog.md Outdated Show resolved Hide resolved
@regisb regisb self-assigned this Dec 12, 2023
@Danyal-Faheem Danyal-Faheem requested a review from regisb December 12, 2023 09:37
@regisb
Copy link
Contributor

regisb commented Dec 12, 2023

@arbrandes what do you think?

arbrandes
arbrandes approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thanks!

@regisb regisb merged commit d39f5be into overhangio:master Dec 18, 2023
1 check passed
@Danyal-Faheem Danyal-Faheem deleted the Danyal-Faheem/document-mfe-patches-catalog branch December 19, 2023 05:28
@regisb regisb mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrandes arbrandes arbrandes approved these changes

@regisb regisb Awaiting requested review from regisb

Assignees

@regisb regisb

Labels
None yet
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Danyal-Faheem @regisb @arbrandes