Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix learner dashboard #174

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

arbrandes
Copy link
Collaborator

Fix a regression introduced by a recently merged patch.

@arbrandes arbrandes requested a review from regisb December 7, 2023 16:08
@arbrandes arbrandes changed the base branch from master to nightly December 7, 2023 16:08
MFEs with URLs that get used "naked" (without any suffixes) require a
trailing slash, because that's what our current PUBLIC_PATH setting
expects.  Without it, these MFEs don't render.
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooooh my bad!

@regisb regisb merged commit 7f2a04f into overhangio:nightly Dec 8, 2023
@arbrandes arbrandes deleted the fix-learner-dashboard branch December 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants