Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dev dependency #166

Merged
merged 2 commits into from
Nov 28, 2023
Merged

feat: dev dependency #166

merged 2 commits into from
Nov 28, 2023

Conversation

CodeWithEmad
Copy link
Member

Having a dev dependency in plugins makes it more maintainable for ci jobs. also, developers can install dev dependencies directly inside each package (a better DevEx)

regisb
regisb requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid making many changes that don't really improve the plugin much. Please remove the commits related to code formatting and renaming the init file.

@CodeWithEmad
Copy link
Member Author

sure. renaming the init file was only in line with what you said earlier

@regisb regisb merged commit b28f25b into overhangio:master Nov 28, 2023
1 check passed
regisb
regisb reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Emad!

@CodeWithEmad CodeWithEmad mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisb regisb regisb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeWithEmad @regisb