feat: add patch to JupyterHub Dockerfile for customization #14
Conversation
Allow for customization of JupyterHub, e.g., installing jupyterhub-idle-culler. This patch enables easier extension of JupyterHub functionality.
| @@ -12,4 +12,6 @@ RUN pip install \ | |||
| jupyterhub-ltiauthenticator==1.6.1 \ | |||
| pymysql==1.1.0 | |||
|
|
|||
| {{ patch("jupyter-hub-dockerfile") }} | |||
There was a problem hiding this comment.
Let's name this "jupyterhub-dockerfile" (see other patches). At the very least, this patch must be documented in the README. Also, please introduce a changelog entry.
There was a problem hiding this comment.
sure, I was orienting myself on jupyter-lab-dockerfile. I'll update the PR shortly
There was a problem hiding this comment.
🤔 maybe you're right. I'll let the maintainer decide of that.
There was a problem hiding this comment.
For consistency with existing patch naming conventions across Tutor plugins, @noeleont lets rename this patch to "jupyterhub-dockerfile". Additionally, I plan to create a separate PR to update the "jupyter-lab-dockerfile" to "jupyterlab-dockerfile" to maintain uniformity and clarity throughout our plugin architecture.
| @@ -1 +1 @@ | |||
| __version__ = "18.1.0" | |||
| __version__ = "18.2.0" | |||
There was a problem hiding this comment.
the version should not be updated here. The maintainer will decide when to release a new version. Please remove this and only add the changelog entry.
Allow for customization of JupyterHub, e.g., installing jupyterhub-idle-culler. This patch enables easier extension of JupyterHub functionality.