Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init task error "'tuple object' has no attribute 'name'". #60

Merged
merged 2 commits into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ instructions, because git commits are used to generate release notes:

<!-- scriv-insert-here -->

<a id='changelog-16.0.3'></a>
## v16.0.3 (2023-12-11)

- [Bugfix] Fix error during init task: "'tuple object' has no attribute 'name'". (by @regisb)

<a id='changelog-16.0.2'></a>
## v16.0.2 (2023-12-09)

Expand Down
2 changes: 1 addition & 1 deletion tutorecommerce/__about__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "16.0.2"
__version__ = "16.0.3"
8 changes: 4 additions & 4 deletions tutorecommerce/templates/ecommerce/tasks/ecommerce/init
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
./manage.py migrate --noinput
./manage.py oscar_populate_countries --initial-only

{% for app in iter_mfes() %}
{% if app["name"] == "payment" %}
{% for app_name, app in iter_mfes() %}
{% if app_name == "payment" %}
./manage.py create_or_update_site \
--site-id=1 \
--site-domain={{ ECOMMERCE_HOST }}:8130 \
Expand All @@ -21,7 +21,7 @@
--payment-support-url="http://{{ LMS_HOST }}:8000/support" \
--discovery_api_url=http://{{ DISCOVERY_HOST }}:8381/api/v1/ \
--enable-microfrontend-for-basket-page=true \
--payment-microfrontend-url="http://{{ MFE_HOST }}:{{ app['port'] }}/{{ app['name'] }}"
--payment-microfrontend-url="http://{{ MFE_HOST }}:{{ app['port'] }}/{{ app_name }}"

# Production site
./manage.py create_or_update_site \
Expand All @@ -43,7 +43,7 @@
--payment-support-url="{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ LMS_HOST }}/support" \
--discovery_api_url={% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ DISCOVERY_HOST }}/api/v1/ \
--enable-microfrontend-for-basket-page=true \
--payment-microfrontend-url="{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ MFE_HOST }}/{{ app['name'] }}"
--payment-microfrontend-url="{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ MFE_HOST }}/{{ app_name }}"
{% endif %}
{% endfor %}

Expand Down
Loading