feat: upgrade to quince #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to renaming quickstart to launch in tutor.
This is to address overhangio/tutor-mfe#122 As a consequence of this change, images will be tagged with a "-nightly" suffix. Next, we'll probably have to build them periodically in CI.
The package version number may not include the "-nightly" suffix. Otherwise, installation fails with: setuptools.extern.packaging.version.InvalidVersion: Invalid version: '15.0.7-nightly'
regisb
reviewed
Nov 21, 2023
| @@ -48,7 +48,7 @@ RUN {% if is_buildkit_enabled() %}--mount=type=cache,target=/openedx/.cache/pip, | |||
| # https://pypi.org/project/setuptools/ | |||
| # https://pypi.org/project/pip/ | |||
| # https://pypi.org/project/wheel/ | |||
| setuptools==67.7.2 pip==23.1.2. wheel==0.40.0 | |||
| setuptools==68.2.2 pip==23.2.1 wheel==0.41.2 | |||
|
|
|||
| # Install a recent version of nodejs | |||
| # https://pypi.org/project/nodeenv | |||
There was a problem hiding this comment.
Please take this opportunity to upgrade to nodeenv 1.8.0.
|
I'm getting the following error during build: |
regisb
reviewed
Dec 8, 2023
tutorecommerce/plugin.py
Outdated
| @@ -60,7 +60,7 @@ | |||
| "MFE_APP": { | |||
| "name": "orders", | |||
| "repository": "https://github.com/edx/frontend-app-ecommerce", | |||
| "port": 1996, | |||
There was a problem hiding this comment.
I address this issue in this PR: https://github.com/overhangio/tutor-ecommerce/pull/57/files
We should merge it (I'll do it now), then rebase the quince branch on top of nightly.
regisb
force-pushed
the
quince
branch
2 times, most recently
from
2f829e3 to
8c043b3
Compare
Repo urls must end with ".git". Otherwise `ADD --keep-git-dir` fails to clone the repo.
regisb
force-pushed
the
quince
branch
2 times, most recently
from
97e23a5 to
0b9c0d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes related to quince upgrade.