-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Upgrade python to 3.12.2 #34
base: main
Are you sure you want to change the base?
Conversation
RUN $PYENV_ROOT/bin/pyenv install $PYTHON_VERSION | ||
RUN $PYENV_ROOT/bin/pyenv global $PYTHON_VERSION | ||
|
||
ENV PATH /opt/pyenv/shims:/opt/pyenv/bin:/scripts:${PATH} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need 2 levels of path here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, we are getting python 3.8 version when we check python version inside container. Including both /opt/pyenv/shims and /opt/pyenv/bin ensures that both the shims and the actual Python binaries managed by pyenv are accessible and utilized correctly within the Docker container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are pulling python 3.8 because the clickhouse-server image is based on ubuntu 22.04:
$ docker run --rm -it docker.io/clickhouse/clickhouse-server:24.1.8 uname -a
ClickHouse Database directory appears to contain a database; Skipping initialization
Linux 327ee7036a61 6.5.0-26-generic #26~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Mar 12 10:22:43 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Let's not attempt to install python 3.12 in this image. We should just wait until the base image is upgraded to ubuntu 24.04 upstream.
Moreover, note that the image was moved from docker.io/yandex/clickhouse-server to docker.io/clickhouse/clickhouse-server: https://hub.docker.com/r/clickhouse/clickhouse-server/tags
See this issue: #30
close #31