Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radial): added canSelect functin and onEvent / onExport field #658

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AstroNext
Copy link

@AstroNext AstroNext commented Oct 22, 2024

added function to check player can select radial menu item or not.
added onEvent field to trigger event when player select radial item

@Skryptific
Copy link
Member

Thank you for the pull request, however it introduces a lot of duplicate code. the canSelect part could be done in a one-liner for example. It would be nice if you could take care of that.

@AstroNext
Copy link
Author

Thank you for the pull request, however it introduces a lot of duplicate code. the canSelect part could be done in a one-liner for example. It would be nice if you could take care of that.

I checked code and I will update PR.

@AstroNext AstroNext changed the title feat(radial): added canSelect functin and onEvent field feat(radial): added canSelect functin and onEvent / onExport field Jan 24, 2025
@AstroNext
Copy link
Author

I have added onExport to use export functionality, similar to onSelect with string type.
I believe the onSelect with string type for export functionality should be removed as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants