Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .bytes() method to various readables #11104

Merged
merged 15 commits into from
May 17, 2024
Merged

add .bytes() method to various readables #11104

merged 15 commits into from
May 17, 2024

Conversation

nektro
Copy link
Member

@nektro nektro commented May 16, 2024

Closes #11049

Copy link
Contributor

github-actions bot commented May 16, 2024

@nektro, your commit has failing tests :(

💪 3 failing tests Darwin AARCH64

💻 2 failing tests Darwin x64 baseline

💻 4 failing tests Darwin x64

🐧💪 1 failing tests Linux AARCH64

🐧🖥 2 failing tests Linux x64 baseline

🐧🖥 1 failing tests Linux x64

🪟💻 12 failing tests Windows x64 baseline

🪟💻 13 failing tests Windows x64

View logs

src/bun.js/base.zig Outdated Show resolved Hide resolved
@Jarred-Sumner Jarred-Sumner changed the title add .body() method to various readables add .bytes() method to various readables May 16, 2024
@nektro nektro marked this pull request as ready for review May 16, 2024 10:29
@nektro nektro requested a review from Jarred-Sumner May 17, 2024 00:31
@nektro nektro merged commit 5caca9c into main May 17, 2024
45 of 53 checks passed
@nektro nektro deleted the jarred/bytes branch May 17, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Request/Response .bytes() method
2 participants