Rename some function #241
Open
Rename some function #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredericBerot-Armand
force-pushed
the
rename-func
branch
from
673a6c9 to
8c80f07
Compare
FredericBerot-Armand
force-pushed
the
rename-func
branch
from
8c80f07 to
ffdce7a
Compare
outscale-mgo
requested changes
Nov 25, 2022
| @@ -344,19 +344,3 @@ func buildOutscaleOAPIDataSourceImagesFilters(set *schema.Set) *oscgo.FiltersIma | |||
| } | |||
| return filters | |||
| } | |||
|
|
|||
| func expandStringValueList(configured []interface{}) []string { | |||
There was a problem hiding this comment.
could you move that to another PR please
| } | ||
| if ownersOk { | ||
| filtersReq.SetAccountIds([]string{aids.(string)}) | ||
| } | ||
| if executableUsersOk { | ||
| filtersReq.SetPermissionsToLaunchAccountIds(expandStringValueList(executableUsers.([]interface{}))) | ||
| filtersReq.SetPermissionsToLaunchAccountIds(utils.InterfaceSliceToStringSlice(executableUsers.([]interface{}))) |
There was a problem hiding this comment.
could you move that to another PR please
| @@ -337,7 +337,7 @@ func dataSourceOutscaleOAPILoadBalancerRead(d *schema.ResourceData, meta interfa | |||
| } | |||
| d.Set("load_balancer_type", lb.LoadBalancerType) | |||
| if lb.SecurityGroups != nil { | |||
| d.Set("security_groups", flattenStringList(lb.SecurityGroups)) | |||
| d.Set("security_groups", utils.StringSlicePtrToInterfaceSlice(lb.SecurityGroups)) | |||
|
|
||
| lb, _, err := readLbs0(conn, d) | ||
|
|
||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| d.Set("subregion_names", flattenStringList(lb.SubregionNames)) | ||
| d.Set("subregion_names", utils.StringSlicePtrToInterfaceSlice(lb.SubregionNames)) |
|
|
||
| d.Set("backend_vm_ids", flattenStringList(lb.BackendVmIds)) | ||
| if err := d.Set("listeners", flattenOAPIListeners(lb.Listeners)); err != nil { | ||
| d.Set("backend_vm_ids", utils.StringSlicePtrToInterfaceSlice(lb.BackendVmIds)) |
| @@ -351,7 +351,7 @@ func dataSourceOutscaleOAPILoadBalancerRead(d *schema.ResourceData, meta interfa | |||
| d.Set("secured_cookies", lb.SecuredCookies) | |||
| d.Set("net_id", lb.NetId) | |||
| d.Set("source_security_group", ssg) | |||
| d.Set("subnets", flattenStringList(lb.Subnets)) | |||
| d.Set("subnets", utils.StringSlicePtrToInterfaceSlice(lb.Subnets)) | |||
| @@ -153,7 +153,7 @@ func dataSourceOutscaleOAPILoadBalancerLDRuleRead(d *schema.ResourceData, meta i | |||
| } | |||
|
|
|||
| if lr.VmIds != nil { | |||
| d.Set("vm_ids", flattenStringList(lr.VmIds)) | |||
| d.Set("vm_ids", utils.StringSlicePtrToInterfaceSlice(lr.VmIds)) | |||
| @@ -166,7 +166,7 @@ func dataSourceOutscaleOAPILoadBalancerLDRulesRead(d *schema.ResourceData, meta | |||
| } | |||
|
|
|||
| if lr.VmIds != nil { | |||
| l["vm_ids"] = flattenStringList(lr.VmIds) | |||
| l["vm_ids"] = utils.StringSlicePtrToInterfaceSlice(lr.VmIds) | |||
| @@ -31,7 +31,7 @@ func dataSourceOutscaleOAPILBUTagsRead(d *schema.ResourceData, meta interface{}) | |||
| names := ename.([]interface{}) | |||
|
|
|||
| req := oscgo.ReadLoadBalancerTagsRequest{ | |||
| LoadBalancerNames: *expandStringList(names), | |||
| LoadBalancerNames: utils.InterfaceSliceToStringSlice(names), | |||
outscale-mgo
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.