Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile use repository field intead of homepage field #37

Closed
wants to merge 1 commit into from
Closed

Conversation

szabgab
Copy link
Contributor

@szabgab szabgab commented May 13, 2024

No description provided.

@jerome-jutteau
Copy link
Contributor

Thanks for the PR, regeneration test seems to fail again. We will have a look a this. ping @outscale-mgo

@outscale-mgo
Copy link
Contributor

outscale-mgo commented May 13, 2024

Hello, I think, this PR should be merged with, #36.
Otherwise, the makefile will generate Cargo.toml, but compare it to the old one, with homepage, and so fail.
Also, in the other PR, you add a \n at the end of Cargo.toml, my guess, is that it should be remove, or the regenerate will fail again.

@outscale-mgo
Copy link
Contributor

see #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants