Config update #668
Merged
Config update #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome-jutteau
requested changes
Sep 22, 2022
v2/config_env_test.go
Outdated
| @@ -49,7 +49,7 @@ func TestEnvVariablesWithProfile(t *testing.T) { | |||
| defer os.RemoveAll(configFolderPath) | |||
|
|
|||
| content := fmt.Sprintf(`{ | |||
| "SomeProfile": { | |||
| "Default": { | |||
There was a problem hiding this comment.
This test is meant to use a specific profile through OSC_PROFILE (see os.Setenv)
| @@ -12,6 +12,8 @@ type ConfigEnv struct { | |||
| OutscaleApiEndpoint *string | |||
| ProfileName *string | |||
| Region *string | |||
| X509ClientCert *string | |||
| X509ClientKey *string | |||
There was a problem hiding this comment.
This is nice to support (and needed in outscale/osc-bsu-csi-driver#355) but those options need to be passed to client configuration to really use client certificates.
Signed-off-by: outscale_hmi <[email protected]>
Signed-off-by: outscale_hmi <[email protected]>
outscale-hmi
force-pushed
the
configUpdate
branch
from
2a599ea to
8f6e0e8
Compare
jerome-jutteau
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.