Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix security group rule creation already exist #368

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix security group rule creation already exist #368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
803ac49
fix security group rule creation already exist
sebglon Sep 3, 2024
68ca049
Update cloud/services/security/securitygroup.go
gvdhart Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cloud/services/security/securitygroup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ func (s *Service) CreateSecurityGroupRule(securityGroupId string, flow string, i
securityGroupRuleResponse, httpRes, err = oscApiClient.SecurityGroupRuleApi.CreateSecurityGroupRule(oscAuthClient).CreateSecurityGroupRuleRequest(createSecurityGroupRuleRequest).Execute()
if err != nil {
if httpRes != nil {
if httpRes.StatusCode == 409 {
return true, nil
}
return false, fmt.Errorf("error %w httpRes %s", err, httpRes.Status)
}
requestStr := fmt.Sprintf("%v", createSecurityGroupRuleRequest)
Expand All @@ -177,7 +180,10 @@ func (s *Service) CreateSecurityGroupRule(securityGroupId string, flow string, i
}
securityGroupRule, ok := securityGroupRuleResponse.GetSecurityGroupOk()
if !ok {
return nil, errors.New("Can not get securityGroup")
// if CreateSecurityGroupRule return 409, the response not contain the conflicted SecurityGroup.
// workarround to a Outscale API issue
return s.GetSecurityGroup(securityGroupId)

}
return securityGroupRule, nil
}
Expand Down