Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(securityGroup): create group whit flag extraSecurityGroupRule #352

Merged

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Aug 6, 2024

What type of PR is this?

/kind bug Fixes securityGroup creation with flag extraSecurityGroupRule enabled

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #351

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@sebglon sebglon force-pushed the fix/security-group/with-flag-extra-rule branch from da55d67 to 62fcb52 Compare August 6, 2024 12:51
Copy link
Contributor

@outscale-hmi outscale-hmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit does not belong to any branch on this repository ?

controllers/osccluster_securitygroup_controller.go Outdated Show resolved Hide resolved
@sebglon sebglon force-pushed the fix/security-group/with-flag-extra-rule branch 2 times, most recently from 446cacf to 55df60c Compare August 12, 2024 12:46
@sebglon sebglon force-pushed the fix/security-group/with-flag-extra-rule branch from 55df60c to 984203f Compare August 12, 2024 12:47
@outscale-hmi outscale-hmi self-requested a review August 19, 2024 07:37
@outscale-hmi outscale-hmi merged commit bee800c into outscale:main Aug 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: fail to create cluster if flag extraSecurityGroupRule enabled at creation
2 participants