fix(oscMachineTemplate): Nil pointer due to error not managed #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log.Error(err, "failed to get machineTemplate.") | ||
| return reconcile.Result{RequeueAfter: 30 * time.Second}, nil | ||
| } | ||
| log.V(2).WithValues("machineTemplateScope", machineTemplateScope).Info("ubble-test") |
There was a problem hiding this comment.
Thank you for your work on this PR. I have a couple of suggestions:
Log Message Update: Please update the log message "ubble-test" to a more descriptive message that accurately reflects the context.
Logging Verbosity: Currently, the logs use log.V(2). High verbosity levels can generate excessive log data in a production environment. Could you please adjust the verbosity level to INFO or another appropriate level ?
There was a problem hiding this comment.
Sorry. this log was only for my debug. removed
sebglon
force-pushed
the
fix/oscmachinetemplate/crashloop-nilpointer
branch
from
328927b to
1aeef7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug Fixes nilPointer on oscMachineTemlate capacity controller
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #341
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: