Feat(cluster-api): add watch filter arg #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebglon
force-pushed
the
feat/cluster-api/add-watch-filter-arg
branch
2 times, most recently
from
9541a0e to
0664fa0
Compare
sebglon
force-pushed
the
feat/cluster-api/add-watch-filter-arg
branch
from
0664fa0 to
def6297
Compare
sebglon
force-pushed
the
feat/cluster-api/add-watch-filter-arg
branch
from
def6297 to
9c8a549
Compare
|
@outscale-hmi can i have a review please? |
outscale-hmi
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
I runned the failed test on local and SGTM,
Thanks for the contribution @sebglon can you please fix the merge conflicts
|
@sebglon Hello, I fixed the boileplate test that failed in your previous commit, can you please rebase and push again and I ll merge as soon as possible |
sebglon
force-pushed
the
feat/cluster-api/add-watch-filter-arg
branch
2 times, most recently
from
26600cc to
057c0aa
Compare
|
@outscale-hmi rebase is done. |
Thanks for the reactivity, tests are good but still have conflicts to be able to merge |
sebglon
force-pushed
the
feat/cluster-api/add-watch-filter-arg
branch
from
aff4281 to
e53c643
Compare
|
@outscale-hmi rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature Add support of watch-filter cluster-api arg
What this PR does / why we need it:
Implement the multi controller instance as describe here by cluster-api
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #330
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Change contrller image;
TODOs: