-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vm): Implement publicIP generation with VM's #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DvdChe
force-pushed
the
feat/vm/implement-public-ip-generation
branch
from
November 29, 2023 14:35
adfd5c8
to
c9c08d8
Compare
sebglon
force-pushed
the
feat/vm/implement-public-ip-generation
branch
from
December 4, 2023 09:53
c9c08d8
to
770264c
Compare
@outscale-vbr ready for review |
sebglon
force-pushed
the
feat/vm/implement-public-ip-generation
branch
from
December 4, 2023 11:12
770264c
to
e348afd
Compare
|
|
Replace message of error |
(There are a new parameters in message of error (PublicIp:false) ) |
Ci passed with those change |
Please rebase also from main |
sebglon
force-pushed
the
feat/vm/implement-public-ip-generation
branch
2 times, most recently
from
December 5, 2023 13:53
fd144e6
to
ac45f85
Compare
@outscale-vbr Rebase is done. |
@sebglon @gvdhart can you just also fix unit-test with missing (PublicIp:false) ?
|
sebglon
force-pushed
the
feat/vm/implement-public-ip-generation
branch
from
December 5, 2023 14:34
ac45f85
to
1503642
Compare
ghost
self-requested a review
December 5, 2023 14:49
ghost
approved these changes
Dec 5, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement publicIP flag on OSCVm resource so that publicIP's can be automatically provisioned and attached to a machine without having to declare them in the Network specs. And so publicIPs work correctly when using machine deployments with more than 1 replica.
DEPENENCIES:
#276
TODOs: