fix mockgen and unit test

Signed-off-by: hanenMizouni <[email protected]>
outscale · Dec 11, 2024 · dc40516 · dc40516
1 parent f3ef74c
commit dc40516
Show file tree

Hide file tree

Showing 7 changed files with 371 additions and 1,680 deletions.
diff --git a/cloud/services/compute/mock_compute/vm_mock.go b/cloud/services/compute/mock_compute/vm_mock.go
diff --git a/controllers/osccluster_bastion_controller.go b/controllers/osccluster_bastion_controller.go
@@ -317,7 +317,7 @@ func reconcileBastion(ctx context.Context, clusterScope *scope.ClusterScope, vmS
 			clusterScope.V(4).Info("Bastion is running", "vmId", vmId)
 		}
 
-		if *bastionState == infrastructurev1beta1.VmStateRunning {
+		if bastionState != nil && *bastionState == infrastructurev1beta1.VmStateRunning {
 			vmId := bastionSpec.ResourceId
 
 			if bastionSpec.PublicIpName != "" && linkPublicIpRef.ResourceMap[bastionPublicIpName] == "" {
@@ -328,7 +328,10 @@ func reconcileBastion(ctx context.Context, clusterScope *scope.ClusterScope, vmS
 				clusterScope.V(4).Info("Get bastionPublicIpName", "bastionPublicIpName", bastionPublicIpName)
 				linkPublicIpRef.ResourceMap[bastionPublicIpName] = linkPublicIpId
 			}
+		} else {
+			clusterScope.V(4).Info("VM is not running, skipping public IP linking")
 		}
+
 	}
 	clusterScope.V(4).Info("Bastion is reconciled")
 	return reconcile.Result{}, nil