-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: description packet's road in butterfly #387
base: develop
Are you sure you want to change the base?
Conversation
Hi, few general comments about documentation:
And particularly to this PR: what about this title: |
78e7c85
to
fccf269
Compare
s/packet's/packets/ |
doc/DESCRIPTION.md
Outdated
|
||
### Poll | ||
|
||
- We collect packets and its numbers in ethernet device queue, store them in array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traduction:
on collecte les paquets et son nombre dans la queue du périphérique ethernet, les stock dans tableau.
doc/DESCRIPTION.md
Outdated
### Poll | ||
|
||
- We collect packets and its numbers in ethernet device queue, store them in array. | ||
- We rebuild all metadata for each packet and burst all packets in opposite direction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We rebuild packets metadata.
Burst them.
doc/DESCRIPTION.md
Outdated
### Burst | ||
|
||
- We collect packets, its numbers, put them in ethernet device queue. | ||
- We burst packets in the queue on ethernet port and free memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put them in ethernet device queue.
We burst packets in the queue so it's not the same operation ?
free memory Which one ?
Signed-off-by: Thiery Ouattara <[email protected]>
fccf269
to
28091bb
Compare
Also, s/Packet road/packet flow/ |
@@ -0,0 +1,88 @@ | |||
DESCRIPTION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DESCRIPTION of what ?
|
||
### Poll: | ||
|
||
- We collect VM packets in the queue. If not packet in the queue it return. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/not/no/
s/in/are in/
## Packets go to VM (VHOST) | ||
|
||
### Burst: | ||
- Vhost bricks got all packet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure of that ^
I mean each brick "got all packets"
@@ -0,0 +1,88 @@ | |||
DESCRIPTION | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might add some schema here:
scenario 1: VM to VM in the same VNI on the same host
/----[Firewall ?]--[Antispoof]--[ sniffer ?]--[vhost, tap or bench brick]
[switch]<
\----[Firewall ?]--[Antispoof]--[ sniffer ?]--[vhost, tap or bench brick]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do other schema latter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scenario 2: VM to VM in the same VNI on diferent host with one VN of the same VNI par host
/- [nic] -- [sniffer ?] -- [vtep] -- [firewall?] -- [antispoof] -- [sniffer ?] -- [vhost, tap or bench brick]
{The WEB} <
\- [nic] -- [sniffer ?] -- [vtep] -- [firewall?] -- [antispoof] -- [sniffer ?] -- [vhost, tap or bench brick]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scenario 3: VM to VM in the same VNI on diferent host with more than 1 VN of the same VNI on 1rst host
/- [firewall?] -- [antispoof] -- [sniffer ?] -- [vhost, tap or bench brick]
/- [nic] -- [sniffer ?] -- [vtep] -- [switch] {- [firewall?] -- [antispoof] -- [sniffer ?] -- [vhost, tap or bench brick]
{The WEB} <
\- [nic] -- [sniffer ?] -- [vtep] -- [firewall?] -- [antispoof] -- [sniffer ?] -- [vhost, tap or bench brick]
Signed-off-by: Thiery Ouattara [email protected]