BACK-1791: ensure prop IPFS gateway gets used instead of pinata #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmalec
requested changes
Nov 9, 2023
| @@ -26,14 +26,23 @@ def __init__( | |||
| max_retries: int = 0, | |||
| async_adapter_configs: Optional[list[AdapterConfig]] = None, | |||
| ) -> None: | |||
| from offchain.metadata.pipelines.metadata_pipeline import ( | |||
There was a problem hiding this comment.
is there a reason to import inside this func?
| @@ -57,35 +66,42 @@ def set_timeout(self, timeout: int): # type: ignore[no-untyped-def] | |||
| """ | |||
| self.timeout = timeout | |||
|
|
|||
| def _get_async_adapter_for_uri(self, uri: str) -> Optional[Adapter]: | |||
| if self.async_adapter_configs is not None: | |||
| for async_adapter_config in self.async_adapter_configs: | |||
There was a problem hiding this comment.
you think this could be slightly rewritten to avoid being deeply nested? also why do we need a for loop with this?
mattmalec
approved these changes
Nov 10, 2023
|
remember to do the release publishing steps! :) |
owen-zora
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: