Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACK-1720: implement HEAD requests for metadata fetcher #92

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

zylora
Copy link
Contributor

@zylora zylora commented Oct 24, 2023

Description

Motivation and Context

When fetching the metadata for a token, we would like to use a HEAD instead of a GET request in order to save web traffic

How has this been tested?

new unit tests in test_arweave_adapter.py test_data_adapter.py test_http_adapter.py test_ipfs_adapter.py test_metadata_fetcher.py test_metadata_pipeline.py

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

BACK-1761: upgrade httpx to 0,25,0
@zylora zylora requested a review from owen-zora October 24, 2023 16:51
@zylora zylora merged commit fce3474 into main Oct 24, 2023
3 checks passed
@zylora zylora deleted the BACK-1720 branch October 24, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants