This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Enhance skygear cloud type definition #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| body?: string; | ||
| } | ||
|
|
||
| interface ResultJSON { |
There was a problem hiding this comment.
This is unused in this commit.
index.d.ts
Outdated
|
|
||
| toResultJSON(): { [key: string]: any }; | ||
| } | ||
| namespace SkygearResponse { |
There was a problem hiding this comment.
I am not a fan of namespace so I prefer interface SkygearResponseOptions
| @@ -489,6 +489,9 @@ declare module "skygear" { | |||
| } | |||
|
|
|||
| declare module "skygear/cloud" { | |||
| import { Fields, Files } from "formidable"; | |||
There was a problem hiding this comment.
It seems that the definition is small enough that we can copy instead.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/formidable/index.d.ts#L32
I would like to reduce the number of dependencies.
| ], | ||
| "dependencies": { | ||
| "@types/formidable": "*", | ||
| "@types/node": "*" |
There was a problem hiding this comment.
We can avoid @types/formidable but not @types/node. Maybe we should mark @types/node as peer dependency and add it to devDependencies so that we still can reference it in our test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can feel the needs to add ci that tests the definition in a server tsconfig.