feat: implement delete facility functionality to moderation panel #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed since on input it was calling out backend. This would cost a lot of money as we call the database every time and that is how payment works on this project. Along with this we do not have many doctors as of now so this isn't a heavy operation for the frontend
This was updated since it is used as a button for a destructive action and in UI design red is for destructive actions
This was componentized as it can be used in the edit submission form and edit facility section. It will help keep the code a bit shorter while having consistent styling in different parts of the moderation dashboard
For the background color of gray inverted was too dark. This failed all the accessibility scores that I check on Figma with the contrast plugin. This plugin checks the scores for the Web Accessibility Initiative Guidelines. This introduces a gray that passes
Previously this function did not use the updated API call as well as the mutation had the wrong input. It should be id not deleteFacilityId
✅ Deploy Preview for findadoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #916
🔧 What changed
🧪 Testing instructions
Tests are being added in ticket #538 currently
📸 Screenshots
Before
After