electron store localLobby Settings schema fix #460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
already fixed in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is a small fix but I did spend some time to figure out the root cause of this issue.
I pulled this project in yesterday and couldn't start the application due to this error:
After some time debugging I realized you probably aware of this issue since you console.loged in line 344 of the Settings file.
I checked the electron-store library as well as avj and found out that you need to have a default object for an object to work otherwise it will not be recognized in the store.
Here is a link to the issue as well in electron-store:
sindresorhus/electron-store#102