-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alpine image to reduce docker image size #2
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd propose using node:lts-alpine
image instead as it would stay on a more production-grade LTS release as a base image instead, while achieving image size reduction that you've proposed.
Completely fair. I haven't had any problems with using the major tag so I never looked into others (like lts)
|
Please don't merge just yet, I'm testing multi stage building to reduce size further |
Feel free to test and (squash) merge if you're happy. |
@Kyle2142 on Docker HUB You see compressed image size, but on localhost You see uncompressed size, that's the difference |
I'm on board with using Alpine, but I just wanted to point out that using 99% of the time, it's fine, but at least as far as the public server goes, I don't really recommend this as it needs all the power it can get. As for everyone else, it likely won't matter. There is a version of Alpine that uses |
Are we waiting for glibc changes or is there some other reason this PR is turning stale? |
I haven't tested further, but at the very least the alpine version starts up after docker build on my raspberry pi (armhf)