Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updating instructions for manual installations #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bls1999
Copy link

@bls1999 bls1999 commented Dec 5, 2020

This pull adds instructions on how to automatically update the code from the repo on the server. It also addresses #12.

Perhaps a future to-do would be to add detection within the code to check to make sure the repo code/packages are all up-to-date and write to the server log if not.

@neil-lobo
Copy link

You may want to add a line as a reminder to restart the process also, since if the server is already running in the background or is being managed by a process manager a simple git pull won't be enough. I'm sure the majority of people would already know to do this but since this is about helping the people who may not know a lot about this kind of stuff it may help avoid some simple issues.

@bls1999
Copy link
Author

bls1999 commented Dec 5, 2020

You may want to add a line as a reminder to restart the process also, since if the server is already running in the background or is being managed by a process manager a simple git pull won't be enough. I'm sure the majority of people would already know to do this but since this is about helping the people who may not know a lot about this kind of stuff it may help avoid some simple issues.

Good call! LMK if a9ea0fa is what you were thinking.

Copy link

@neil-lobo neil-lobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

@@ -103,6 +103,22 @@ yarn start
```
4. Copy your server's IP and port into CrewLink settings. Make sure everyone in your lobby is using the same server.

### Updating

1. Navigate to the directory containing the CrewLink server.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Navigate to the directory containing the CrewLink server.
1. Navigate to the directory containing the CrewLink-server codebase.

```sh
yarn install
```
4. Restart the server (if running).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command(s) to run for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants