Chore: setup postgres and vector in dockerfile #677
+67
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
requested review from
ibuildthecloud,
cjellick,
thedadams,
njhale,
iwilltry42 and
g-linville
cjellick
reviewed
Nov 26, 2024
|
|
||
| # Setup postgres and postgres-vector, although in production setup we don't really need standalone postgres | ||
| RUN apk add postgresql build-base git postgresql-dev | ||
| RUN git clone --branch v0.8.0 https://github.com/pgvector/pgvector.git && \ |
There was a problem hiding this comment.
darren mentioned this fleetingly when the feasibility of this was discussed. i should have passed it along sooner. he said you could just get it via from, like
FROM pgvector/pgvector:pg17
or whatever. i think that would be a little cleaner and more official feeling?
There was a problem hiding this comment.
yep, I did detour to avoid dropping wolfi-base image we already uses.
thedadams
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should configure postgres and pgvector into otto dockerfile. It will run and use the built-in postgres process if no OTTO8_SERVER_DSN is set.
I ran some test against knowledge ingestion and it works fine.