Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix monster attack behavior #4866

Merged
merged 6 commits into from
Dec 29, 2024

Conversation

ArturKnopik
Copy link
Contributor

@ArturKnopik ArturKnopik commented Dec 4, 2024

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Fix monster attack behavior

Issues addressed:
#4865

How to test:
go to monsters using normal character
Troll - hit to red, let them fleeing
Cyclops
Hunter
Rabbit
IDK if there is monster with different walking mechanic

@ghost ghost requested review from ranisalt, nekiro and MillhioreBT December 5, 2024 02:02
@ghost ghost linked an issue Dec 5, 2024 that may be closed by this pull request
4 tasks
@nekiro
Copy link
Member

nekiro commented Dec 5, 2024

imo there is missing updateFollowCreaturePath(fpp); after this code so specifically:


to

} else {
    updateFollowCreaturePath(fpp);
}

genuinely sad this code was merged, its broken at the first sight when joining the game and checking
that elseif you changed was correct, its for ranged monsters afaik

@ArturKnopik
Copy link
Contributor Author

@nekiro @ramon-bernardo, can you test my fix?

src/monster.cpp Outdated Show resolved Hide resolved
src/monster.cpp Show resolved Hide resolved
@ramon-bernardo
Copy link
Contributor

Unfortunately, i cant test it because my cip client doesn't connect to login server. I could try using OTClient, but not sure if it support v13

@nekiro nekiro force-pushed the fix_monsterAttackBehavior branch from de13716 to 80fcd85 Compare December 29, 2024 18:53
@nekiro nekiro merged commit c85df89 into otland:master Dec 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Monster not following target
3 participants