fix: allow disabling specific calculations #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiceAesth
requested review from
cmyui,
skrungly,
tsunyoku and
7mochi
as code owners
1 task
tsunyoku
approved these changes
Feb 13, 2024
cmyui
reviewed
Feb 15, 2024
| @@ -219,25 +219,26 @@ async def recalculate_mode_scores(mode: GameMode, ctx: Context) -> None: | |||
|
|
|||
| async def main(argv: Sequence[str] | None = None) -> int: | |||
| argv = argv if argv is not None else sys.argv[1:] | |||
| if len(argv) == 0: | |||
| argv = ["--help"] | |||
There was a problem hiding this comment.
does it still behave the same way after the change here?
There was a problem hiding this comment.
Forcing that argument on makes it impossible to run it without args (which runs on all modes all calcs)
You need to add --help now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Addresses issues raised in #573
Added
tzdatato dependencies, meant to pr separately but oh wellRelated Issues / Projects
Checklist