Skip to content

Commit

Permalink
remove character from being required in player.ex, remove character s…
Browse files Browse the repository at this point in the history
…ections in instructions on lobby and all character icons

References #22
  • Loading branch information
isnide23 committed Nov 9, 2021
1 parent 7fcd494 commit 092b058
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/dream_up/players/player.ex
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ defmodule DreamUp.Players.Player do
def changeset(player, attrs) do
player
|> cast(attrs, [:name, :game_id, :team, :team_leader, :character, :game_admin])
|> validate_required([:name, :game_id, :team, :character])
|> validate_required([:name, :game_id, :team])
end
end
12 changes: 6 additions & 6 deletions lib/dream_up_web/live/lobby_live.html.leex
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
["Red": "red", "Blue": "blue"],
value: input_value(f, :team)
%>
<label for="player_character"> Character </label>
<%# <label for="player_character"> Character </label>
<%= select f, :character,
["Artist": "artist", "Storyteller": "storyteller", "Dreamer": "dreamer", "Planner": "planner", "Listener": "listener", "Maker": "maker", "Rebel": "rebel", "Writer": "writer", "Thinker": "thinker" ],
value: input_value(f, :character)
Expand Down Expand Up @@ -92,13 +92,13 @@
<p>
If you know which color team you want to join, select that color. If you do not, pick a random color. Once everyone has joined, teams can be rebalanced as needed.
</p>
<p>
<%# <p>
Pick a Character card that you feel best expresses your personality, working style, or skills.
</p>
</p> %>
</div>
</div>
<%# character image grid %>
<div class="grid gap-4 md:grid-cols-3">
<%# <div class="grid gap-4 md:grid-cols-3">
<div class="character">
<img src="/images/characters/maker.png">
<p>The Maker</p>
Expand Down Expand Up @@ -135,14 +135,14 @@
<img src="/images/characters/storyteller.png">
<p>The Storyteller</p>
</div>
</div>
</div> %>
<% else %>
<%# instructions - post join %>
<div class="lobby-instructions-container">
<div class="lobby-instructions">
<h1>Instructions:</h1>
<p>
As the two teams are formed, you will see the members of the teams listed including the character they selected. The team leaders' names will be in bold. 
As the two teams are formed, you will see the members of the teams listed. The team leaders' names will be in bold. 
</p>
<p>
Check to see if teams need to be rebalanced (in terms of numbers of people and characters selected). 
Expand Down

0 comments on commit 092b058

Please sign in to comment.