fix srs-server helm chart port config problem. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix the srs container ports config, must be hardcode to predefined ports; 2. add comments to remind don't simplify config replicaCount or open autoscaling, those config is for stateless app deployment, e.g. srs edges; 3. add startupProbe and change livenessProbe to /api/v1/versions endpoint, this change don't fix anything, just add more container proble and its default configs: failtureThreshold, periodSeconds;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce Port Config problem?
In
mainbranch.helm install srs srs-server/ --debug --set service.http=8088http://localhost:8088in web browser. No response.