🌱 Logging a warning if readGitHubTokens finds several values which clash. #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Heidrich <[email protected]>
aunovis-heidrich
requested review from
spencerschrock and
raghavkaul
and removed request for
a team
aunovis-heidrich
temporarily deployed
to
gitlab
GitHub Actions
Inactive
aunovis-heidrich
had a problem deploying
to
integration-test
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4483 +/- ##
==========================================
+ Coverage 66.80% 68.46% +1.65%
==========================================
Files 230 246 +16
Lines 16602 18444 +1842
==========================================
+ Hits 11091 12627 +1536
- Misses 4808 4991 +183
- Partials 703 826 +123 |
Signed-off-by: Simon Heidrich <[email protected]>
Signed-off-by: Simon Heidrich <[email protected]>
Signed-off-by: Simon Heidrich <[email protected]>
…dered the line too long. Signed-off-by: Simon Heidrich <[email protected]>
aunovis-heidrich
temporarily deployed
to
gitlab
GitHub Actions
Inactive
aunovis-heidrich
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Print a warning if several GitHub Access Tokens with different values are found.
What is the current behavior?
Scorecard ignores any GitHub PAT environment variables after the first one it finds.
What is the new behavior (if this is a feature change)?**
Scorecards checks all possible PAT env vars and prints a warning if their values differ. It still uses the first one it finds, such that the behaviour is non-breaking.
Which issue(s) this PR fixes
Fixes #4475
Special notes for your reviewer
The local tests failed already for a clean checkout of the main branch. I am hoping for the CI to sucessfully run them for me.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)