Small PythonInspector-related simplifications
#8108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of version 0.9.3 [1], `python-inspector` also supports "dotted" versions. [1]: https://github.com/nexB/python-inspector/blob/main/CHANGELOG.rst#v093 Signed-off-by: Sebastian Schuberth <[email protected]>
The variable names are now all exactly the same as the parameter names, so there is no benefit in used named arguments. Signed-off-by: Sebastian Schuberth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8108 +/- ##
=========================================
Coverage 67.15% 67.15%
Complexity 2054 2054
=========================================
Files 358 358
Lines 17164 17164
Branches 2462 2462
=========================================
Hits 11526 11526
Misses 4615 4615
Partials 1023 1023
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mnonnenmacher
approved these changes
Jan 12, 2024
|
Blocked by aboutcode-org/python-inspector#167. |
mnonnenmacher
changed the title
PythonInspector-related simplifictionsPythonInspector-related simplifications
|
Abandoning this as it's unclear if and when the upstream issue will be solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.