create persisted items with custom useLocalStorage hook #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomastauer
reviewed
Apr 5, 2024
src/app/hooks/useLocalStorage.ts
Outdated
| return storedValue | ||
| ? JSON.parse(storedValue) | ||
| : JSON.parse( | ||
| localStorage.getItem('items') ?? |
There was a problem hiding this comment.
I don't think we need to load the "default key", in this case "items". The key argument passed to the hook cannot be undefined, so there is no need for default value
|
Thanks for code review. Now it definitely looks better. Last thing are failing tests :( |
the reason for failing tests is keeping the state between the test cases (as the local storage is available to some extent for tests as well, storing something in one test will influence the others) I have added clean up to the test file, now the tests will pass |
tomastauer
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
items are not persisted in memory
Describe your changes
create persisted items with custom useLocalStorage hook
closes #7