Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download Packages.gz instead of Packages #89

Merged
merged 1 commit into from
Sep 4, 2020
Merged

download Packages.gz instead of Packages #89

merged 1 commit into from
Sep 4, 2020

Conversation

mathias-luedtke
Copy link
Contributor

While working on osrf/docker_images#376 I came up with this little improvement.

For my connection, it saves >50% time for ros/create_dockerfiles.py dir -d ros/melodic/ubuntu/bionic/

ruffsl
ruffsl approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@ruffsl ruffsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@mikaelarguedas
Copy link
Contributor

Works nicely thanks @ipa-mdl !

I gave that a shot on the ROS dockerfiles generation:
without the patch

# time ./create_dockerfolders.py dir -d . -a
real	2m27.026s
user	0m2.923s
sys	0m0.276s

With the patch

# time ./create_dockerfolders.py dir -d . -a
real	1m4.539s
user	0m3.020s
sys	0m0.083s

@mikaelarguedas mikaelarguedas merged commit ab57137 into osrf:master Sep 4, 2020
@mathias-luedtke mathias-luedtke deleted the feature/packages.gz branch September 4, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

@ruffsl ruffsl ruffsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathias-luedtke @mikaelarguedas @ruffsl