Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to gpg keyring for non-EOL images #705

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Move to gpg keyring for non-EOL images #705

merged 7 commits into from
Dec 20, 2023

Conversation

mikaelarguedas
Copy link
Contributor

@mikaelarguedas mikaelarguedas commented Dec 19, 2023

Will close #621 and follow guidelines provided in docker-library/official-images#15809 (comment)

Will result in docker-library/official-images#15936

export GNUPGHOME="$(mktemp -d)"; \
gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key"; \
mkdir -p /usr/share/keyrings; \
gpg --batch --export "$key" > /usr/share/keyrings/pkgs-osrf-archive-keyring.gpg; \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-rivero I followed the install location from the gazebo docs

Do you confirm the keyring should be installed in /usr/share/keyrings and not in /etc/apt/keyrings?
Same for the ROS ones ? (@nuclearsandwich ?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you confirm the keyring should be installed in /usr/share/keyrings and not in /etc/apt/keyrings?
Same for the ROS ones ? (@nuclearsandwich ?)

Following https://wiki.debian.org/DebianRepository/UseThirdParty

If future updates to the certificate will be managed by an apt/dpkg package as recommended below, then it SHOULD be downloaded into /usr/share/keyrings using the same filename that will be provided by the package. If it will be managed locally , it SHOULD be downloaded into /etc/apt/keyrings instead.

Our intention is to manage the ROS/Gazebo keys using a package )hopefully sometime in the short future). So I'm inclined to use /usr/share/keyrings as suggested by the Debian documentation.

@mikaelarguedas mikaelarguedas merged commit f90e7e8 into master Dec 20, 2023
14 checks passed
@mikaelarguedas mikaelarguedas deleted the gpg-keyring branch December 20, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rolling: apt-key deprecation warning
2 participants