-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EOL distros need to use snapshots.ros.org #278
Conversation
This doesn't seem to fix the build. Take boxturtle for example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not passing build.
It's interesting. cd /tmp/
git clone https://github.com/eisoku9618/docker_images.git -b fix-for-eol-distro
docker build --tag=ros:boxturtle-ros-lucid --no-cache docker_images/ros/boxturtle/ubuntu/lucid/ros/. output log of docker build inside my PC
How did you get the log output? In travis, I could not find any boxturtle test. |
I think it may be my hotel wifi, as I just tested the PR branch locally above, but when I test remotely on my workstation at work it seems to build. Ok then. BTW, could you link to the announcement for the snapshot public key bits, as I couldn't find it from any of the recent official announcements. |
It looks like the snapshot key in here matches the one documented on the ROS wiki and the analog PR to the templates. @ruffsl Is the plan to iterate on this + #269 ? or to iterate on #278 that includes both the key and repo changes? |
As @mikaelarguedas mentioned, I copied the public key bits from osrf/docker_templates#64 . |
@eisoku9618 , could you open a PR to update the docker_template repo for legacy image. |
@ruffsl Would osrf/docker_templates#64 be sufficient ? |
No description provided.