-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ARM64v8 architecture #174
Conversation
deb1c04
to
54b54c5
Compare
Okay, finally Guys, can you please check this PR and provide your valuable comments. I have verified this on both Regards, |
Looks like you added a duplicate entry for version 9. Instead you just need to insert docker_images/gazebo/manifest.yaml Line 115 in a136b53
and here: docker_images/gazebo/manifest.yaml Line 126 in a136b53
|
Thanks @ruffsl I have modified this PR, as per your guidance. Regards, |
Looks like Version '9.3.1-1*' is not currently available for arm64v8, as testing out the gazebo9 images with |
@ruffsl Actually, This is the available mapping right now at Gazebo URL for ARM64: **Ubuntu ** This was reason that my earlier commit had duplicate entries for Gazebo9, one for Debian and other for Ubuntu. Can you please suggest what should be next approach. My target is to include Regards, |
Presently, we pull the latest available release version by checking Going forward, I'd expect we could transition pulling the yaml file that @mikaelarguedas linked to in his comment, although I'm not sure gazebo has the same yaml artifacts from its build farm yet as well. Then we could adopt either two different maintenance schemas, I.e. specifying exact version numbers on a per architecture basis (#112) or maintaining separate dockefiles per architecture (#115). What eventually resolves #112 will most likely resolve this issue. |
- Update manifest to fetch latest architecture based gazebo from available distributions. - Add Debian based Gazebo to support both AMD64 & ARM64. Signed-off-by: Odidev <[email protected]>
Going by official support of Gazebo-9 for ARM64v8, I can see that this is supported for Debian:Stretch distribution instead of Ubuntu. I have updated the PR to use Debian:Stretch. Regards, |
Why do we have to introduce a new distro (Debian) to support ARM64? Ubuntu Bionic seems to work just fine. |
Closing in favor of #205 |
from available distributions.
This will also work for AMD64 to fetch available packages.
This PR extends support for Gazebo package for
arm64v8
architecture.A user needs to execute
manifest.yaml
to update code-base to generate all the available distribution packages.Then
docker build
can be executed from the desired folder.Currently,
arm64v8
is supported ingazebo/9/debian/stretch/
Signed-off-by: Odidev [email protected]