Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARM64v8 architecture #174

Closed
wants to merge 1 commit into from

Conversation

odidev
Copy link

@odidev odidev commented Jul 16, 2018

  • Update manifest to fetch latest architecture based gazebo
    from available distributions.
    This will also work for AMD64 to fetch available packages.

This PR extends support for Gazebo package for arm64v8 architecture.
A user needs to execute manifest.yaml to update code-base to generate all the available distribution packages.
Then docker build can be executed from the desired folder.

Currently,arm64v8 is supported in gazebo/9/debian/stretch/

Signed-off-by: Odidev [email protected]

@odidev odidev force-pushed the gazebo_arm64 branch 2 times, most recently from deb1c04 to 54b54c5 Compare August 7, 2018 04:34
@odidev
Copy link
Author

odidev commented Aug 7, 2018

Okay, finally All checks have passed.
Looks so good to see this message after so many conflict issues.

Guys, can you please check this PR and provide your valuable comments.

I have verified this on both amd64 and arm64v8 architectures.
I can also provide build and run logs as required for confirmation.

Regards,

@ruffsl
Copy link
Member

ruffsl commented Aug 15, 2018

Looks like you added a duplicate entry for version 9. Instead you just need to insert - arm64v8 under this line here:

and here:

@odidev
Copy link
Author

odidev commented Aug 17, 2018

Thanks @ruffsl

I have modified this PR, as per your guidance.

Regards,

@ruffsl
Copy link
Member

ruffsl commented Aug 17, 2018

Looks like Version '9.3.1-1*' is not currently available for arm64v8, as testing out the gazebo9 images with FROM arm64v8/ubuntu:bionic fails.

@odidev
Copy link
Author

odidev commented Aug 20, 2018

@ruffsl
Hi Ruffin,
Yes, I do agree with your concern.
Indeed 9.3.1-1* is not present for arm64.

Actually,Gazebo9 is not present for arm64 from official gazebo url.
But it is there for debian.

This is the available mapping right now at Gazebo URL for ARM64:
Debian
Stretch - Gazebo-9.0.0-2

**Ubuntu **
Xenial - Gazebo-8.0.0-1
Zesty - Gazebo-8.0.0-2

This was reason that my earlier commit had duplicate entries for Gazebo9, one for Debian and other for Ubuntu.

Can you please suggest what should be next approach.
Or can you take it at your end, as it will even more faster approach.

My target is to include gazebo in official list of arm64v8 as soon as possible.

Regards,

@ruffsl
Copy link
Member

ruffsl commented Aug 20, 2018

Presently, we pull the latest available release version by checking packages.osrfoundation.org/gazebo, e.g. here. Because only one dockerfile is used for all available architectures, this inevitably leads to issues when the latest release for other architectures are not in sync with amd64, the architecture used by default. This issue is being tracked here: #112 .

Going forward, I'd expect we could transition pulling the yaml file that @mikaelarguedas linked to in his comment, although I'm not sure gazebo has the same yaml artifacts from its build farm yet as well. Then we could adopt either two different maintenance schemas, I.e. specifying exact version numbers on a per architecture basis (#112) or maintaining separate dockefiles per architecture (#115).

What eventually resolves #112 will most likely resolve this issue.

 - Update manifest to fetch latest architecture based gazebo
   from available distributions.
 - Add Debian based Gazebo to support both AMD64 & ARM64.

Signed-off-by: Odidev <[email protected]>
@odidev
Copy link
Author

odidev commented Aug 23, 2018

Going by official support of Gazebo-9 for ARM64v8, I can see that this is supported for Debian:Stretch distribution instead of Ubuntu.

I have updated the PR to use Debian:Stretch.

Regards,

@lag-linaro
Copy link

Why do we have to introduce a new distro (Debian) to support ARM64?

Ubuntu Bionic seems to work just fine.

@ruffsl
Copy link
Member

ruffsl commented Nov 16, 2018

Closing in favor of #205

@ruffsl ruffsl closed this Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants