Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tm-db master branch #1442

Merged
merged 8 commits into from
Jun 2, 2022
Merged

Use tm-db master branch #1442

merged 8 commits into from
Jun 2, 2022

Conversation

faddat
Copy link
Member

@faddat faddat commented May 6, 2022

Closes: #XXX

What is the purpose of the change

Working to overhaul tm-db upstream. This should enable the use of badgerdb v3, and soon (after another update) it will allow rocksdb to work
without manaully making a snapshot folder.

Brief change log

  • bump tm-db

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no) NO
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no) YES
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@faddat faddat requested a review from a team May 6, 2022 20:56
@faddat
Copy link
Member Author

faddat commented May 7, 2022

NB: tendermint/tm-db#248

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #1442 (045c622) into main (e9062fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1442   +/-   ##
=======================================
  Coverage   19.60%   19.60%           
=======================================
  Files         242      242           
  Lines       32279    32279           
=======================================
  Hits         6329     6329           
  Misses      24792    24792           
  Partials     1158     1158           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9062fc...045c622. Read the comment docs.

@p0mvn
Copy link
Member

p0mvn commented May 9, 2022

Thanks for this PR @faddat . This version of tm-db seems to be unreleased yet. Can we wait until there is an actual release before updating it?

@faddat
Copy link
Member Author

faddat commented May 19, 2022

@p0mvn I don't know if there ever will be one.

My understanding is that both the tendermint and cosmos teams would like to sunset it.

@ValarDragon
Copy link
Member

I'm good with merging this, but if its alright I'd like us to get a smooth v9.0.0 release, and then try this out in a patch release?

@ValarDragon
Copy link
Member

oh just read the changes in tm-db, lets just go ahead and merge this to main. I'm down to backport after an initial v9 release.

Can go ahead and backport to v8 if someone wants to experiment with it

@mergify mergify bot merged commit 8b1c2c0 into main Jun 2, 2022
@mergify mergify bot deleted the faddat/tm-db-master branch June 2, 2022 19:35
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants