Add classes to style #1151
Draft
Add classes to style #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshcherb
reviewed
Nov 12, 2024
| </renderingClass> | ||
| <renderingClass name=".surface" title="Road surface" enable="true"/> | ||
| <renderingClass name=".surface_grade" title="Road surface grade" enable="true"/> | ||
| <renderingClass name=".access" title="Road access" enable="true"> |
vshcherb
reviewed
Nov 12, 2024
| @@ -9183,7 +9200,7 @@ | |||
| </case> | |||
| <case minzoom="12" tag="leisure" value="garden" color="$gardenColor"/> | |||
| <apply> | |||
| <switch minzoom="16" showAccess="true"> | |||
| <switch minzoom="16" showAccess="true" rClass=".road.access"> | |||
| <case additional="access=private" color_2="$accessPrivateColor"/> | |||
There was a problem hiding this comment.
should it be clasess by access tag? .road.access.private or dynamic class by acces stag
vshcherb
reviewed
Nov 12, 2024
rendering_styles/default.render.xml
Outdated
| <switch> | ||
| <switch baseAppMode="car"> | ||
| <switch rClass=".road.access"> | ||
| <switch baseAppMode="car" rClass=".road.access.vehicle.$vehicle,.road.access.motor_vehicle.$motor_vehicle,.road.access.motorcar.$motorcar"> |
There was a problem hiding this comment.
this won't work as too complicated class.
You need to write here each class individuall
<case additional="vehicle=no" .road.access.motor_vehicle_no />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.