Show before-and-after sample images in GitHub workflow #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleedev
reviewed
Oct 8, 2023
jleedev
reviewed
Oct 8, 2023
ZeLonewolf
commented
Oct 24, 2023
ZeLonewolf
commented
Oct 24, 2023
|
Looks like the PR preview isn't pulling in the web font. The Interstate 40 shield has the wrong width. |
jleedev
reviewed
Nov 2, 2023
ZeLonewolf
commented
Dec 13, 2023
src/js/shield_defs.js
Outdated
| ["HIST"], | ||
| ["XYZA"], |
There was a problem hiding this comment.
This change will be reverted prior to merging. I changed it in order to demonstrate what a before-and-after sample would look like in the build actions.
ZeLonewolf
commented
Dec 13, 2023
| "name": "athens_ga_7_way_concurrency", | ||
| "viewport": { | ||
| "width": 400, | ||
| "height": 400 |
There was a problem hiding this comment.
I added this because it's a good sample location for multiple-concurrency shields and shield coloration.
ZeLonewolf
force-pushed
the
zlw-sample-diff
branch
from
39c31b2 to
01f6dbc
Compare
Ensure that we capture stats from the PR branch
|
Is the PR Preview supposed to have a preview of all the sample locations? Things look good to me, cool feature. |
|
The preview is intended to only show sample locations for places where the PR changes the rendering from what's in the main branch. |
|
Thanks @akadouri for your review, are you good with merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #958
This PR add before and after image samples to the "PR Preview" GitHub check tab. It only shows locations where there is a change in rendering. The sample locations are defined in tests/sample_locations.json. The before and after images are generated in userland, uploaded to s3, while a markdown file with the change is pushed over the the privileged CI runner.
I had to change the GitHub action to run the before and after builds in separate folders so they wouldn't stomp on each other. I also use the PR branch's render test list and apply it to both the main and PR branch. This ensures that we have apples to apples comparisons. For this reason, the comparison and clipping scripts are also run out of PR branch code.
I also tweaked some of the sample location sizes and added a dense area of NYC and a recently located 7-way concurrency because Americana :)
I've also made a change the Historic US-66 to demonstrate the change in the checks tab, however, I will remove that change prior to merging this PR.
Below is what it looks like in the checks tab, and you can click down in the checks to view it. There are links to the location in the current demo map as well as the PR preview map.
If we think it's useful, a future PR could also generate an image diff to show the pixel differences, perhaps using pixelmatch.