Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-shield banner colors #941

Merged
merged 8 commits into from
Oct 6, 2023
Merged

Per-shield banner colors #941

merged 8 commits into from
Oct 6, 2023

Conversation

ZeLonewolf
Copy link
Member

Fixes #357

This PR allows the style to specify the color of a shield's banner on a per-shield basis. If set, the color will apply to all banners on a shield. Additionally, the style can specify the halo knockout color on a per-shield basis.

Additionally:

  • Banner rendering code was consolidated into a new file, shield_banner.ts, for improved code navigation and readability.
  • Banner colors were implemented for Vermont alternate routes (green) and US Numbered Highway System historic routes (brown).

Samples:
image
image

@claysmalley claysmalley added shield-generator Issues specific to the shield library enhancement New feature or request labels Oct 5, 2023
@claysmalley
Copy link
Member

Off the top of my head, these other networks should be changed as well:

  • GLCT:Loop, brown
  • US:CA:Business, green
  • US:MD:Business, green
  • US:NJ:ACE:Connector, blue
  • US:NJ:CR:Spur, blue
  • US:NJ:CR:Truck, blue
  • US:OH:ASD:TWP, green
  • US:OH:ATH:Trimble, green
  • US:OH:MED:York, blue
  • US:OH:PAU:Latty, green
  • US:OH:PAU:Washington, green
  • US:OH:WAS:Aurelius, green
  • US:OH:WAS:Salem, green
  • US:SC:Truck, blue
  • US:SC:Business, blue
  • US:SC:Alternate, blue
  • US:TX:Recreational, brown
  • US:TX:Express:Toll, blue
  • US:TX:Loop:Toll, blue
  • US:TX:Loop:Express:Toll, blue
  • US:TX:CTRMA:Express, blue
  • US:TX:Jackson, blue
  • US:TX:Andrews:Andrews:Loop, blue
  • AU:*:ALT, green
  • AU:*:ALT_S, blue

@ZeLonewolf
Copy link
Member Author

I've added all the listed banners except for the Ohio ones because that code is complicated. #943 documents updating the Ohio shield banners to the right colors.

Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

@ZeLonewolf ZeLonewolf merged commit 38268fb into main Oct 6, 2023
6 checks passed
@ZeLonewolf ZeLonewolf deleted the zlw-color-banners branch October 6, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shield-generator Issues specific to the shield library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colored Banners
2 participants