Add places of worship

[wmisener]

Fixes #861.

This PR adds places of worship. The icon is based on the classic US atlas style of a square topped with a religious icon. The initial PR contains the places of worship of the 8 religions given an icon in Carto: Buddhist, Christian, Hindu, Jewish, Muslim, Sikh, Shinto, and Taoist. The symbols I chose are:

• Buddhist: wheel/dharmachakra
• Christian: cross
• Hindu: om
• Jewish: star of David
• Muslim: star and crescent
• Shinto: torii
• Sikh: khanda
• Taoist: yin-yang

Places of worship do not necessarily fall neatly into any of the defined POI color categories. The initial PR uses attraction-brown, but there were suggestions in slack discussions for infrastructure-blue or perhaps its own color (maybe gray?). I'm open to suggestion on colors.

Other religions could be considered. Some other common religion values in the United States include unitarian_universalist (518 place_of_worship) and bahai (79). This PR also lacks distinct icons for LDS and Jehovah's Witness places of worship, which are rendered with crosses. Distinct renderings are blocked by OMT, which does not contain any denomination information that could distinguish these from other Christian POWs.

Samples:
Christian and Hindu (localhost link):

Buddhist, Christian, Jewish, and Shinto (localhost link):

Christian and Muslim (localhost link):

Buddhist, Christian, and Taoist (localhost link):

Christian and Sikh (localhost link):

Legend sample:

I opted for the uniform "place of worship" rather than attempting to name each religion's.

Jerusalem Temple Mount (localhost link):

[github-actions]

PR Preview:

• Map
• Shield Test
• style.json
• shields.json
• taginfo.json

Sprite Sheets:

[ZeLonewolf]

Thanks for taking this on!

There was a Slack discussion that discussed PoW icons and in summary I think we need to:

1. Use the "community anchor blue" color scheme for PoWs
2. The other-than-Christian symbols are too fine and the features should be thickened a bit so that they have the same effective visual weight

There was also some discussion about modifying the base rectangle size if needed for effective size contrast between the symbol and the base.

[wmisener]

Updated the PR to color the symbols blue and add thicker lines for the Star of David. I'll continue iterating the symbol relative sizes via slack, though I can also post the test screenshots here if anyone desires

[1ec5]

id-tagging-schema calls this tagging combination simply “Christian church”, and there are other religion-specific descriptions for other religion values.

[wmisener]

I'm open to this, and considered it for the initial PR, though I worried it gets into complicated terminology issues quickly. For instance, not all amenity=place_of_worship + religion=christian are churches (like LDS Temples or even holy wells), some sects of Judaism call their houses of worship 'temples' or 'shuls' instead of synagogues, what iD labels as "Sikh temples" are actually called gurdwaras, etc. But maybe these are small potatoes compared to the improvement in how understandable the legend would be.

[1ec5]

That’s true, your point probably matters more in the context of a public-facing map like Americana than something internal to OSM like iD. The diplomatic “place of worship” terminology isn’t inaccurate, just wordy, but we have enough room for it.

[wmisener]

Ah thanks for going ahead and merging, I've been busy with work lately and haven't had much time to work on this. I think as some of the comments here and on Slack have noted, if it turns out "in the wild" that the religious symbols are too small, it could potentially be useful to make the squares slightly smaller and the icons slightly bigger. I'll also open separate issues to track other potential religions.