-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aerialways #755
add aerialways #755
Conversation
src/js/legend_config.js
Outdated
@@ -40,6 +41,10 @@ export const sections = [ | |||
name: "Railroads", | |||
entries: RailLayers.legendEntries, | |||
}, | |||
{ | |||
name: "Aerialways", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think “aerialway” is only a real word in OSM English. Both aerial trams and chair lifts count as aerial lifts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chairlifts or gondolas on the east coast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tram sounds like some quaint en_GB thing to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aerial lift sounds good to me as a general term.
The two transit-oriented aerial lifts I know of in the United States have tram in their names:
I think "aerial tramway" in US English is reasonably understood to be a transit-oriented aerialway=gondola
or aerialway=cable_car
. But at a ski resort, I'd definitely call that a gondola.
Shucks, |
Yeah, a little background on that: |
The bright red makes these features very visually prominent, and thus by implication very important (though the width adjustment helped make them a bit more muted). That prominence makes sense enough on a map of a single ski resort, especially with their snow-white backgrounds, but I'm not sure it's right for a general purpose map. I don't know if these aerialways are that much more important to a typical user than, e.g., railways, which render much more subtly. This especially strikes me in the examples in urban settings. On Americana so far, red has been reserved for freeways and trunk roads, so this would change/dilute the meaning of the color red in the style. The current casing style also makes them look quite similar to a trunk-expressway IMO. I wonder if it would be more consistent for these features to be purple, the designated "transportation" color (although I think airports are the only thing rendered in that class so far), as has been toyed with for busways in #477. |
I agree that it would be confusing to overload red to mean either an important road or something very different, especially since the two can cross. There’s a limit to how much inspiration we can draw from a site map of any kind, whether a ski resort, golf course, or shopping mall, since a site map can afford to deemphasize anything off-site considerably. If we need to maintain a connection to ski resort maps, perhaps pink (with a white casing) would be sufficiently distinct from a road, but it would need to be desaturated a bit to avoid overwhelming the map. |
Color aside, I think these might benefit from rendering little dots for the endpoints, any intermediate stations, and maybe at higher zooms the osm-carto takes a nod at this approach but doesn't use the actual locations of the poles, just a pattern, which I personally find a little misleading and silly-looking at high zooms. |
Aerialway stations tracked in #692. I think matching the color of aerialway lines is a good idea. Unfortunately |
+1 for the purple option. I like how it fits the transit theme and also its visual weight. It's distinctive enough to be able to follow through the myriad grayscale lines of Bolivia without jumping out too much. |
Also, at very high zooms the knockout might be dropped to let the wires stand alone as they cross over buildings and other features at something approximating a realistic width. With pylons (at some point) that effect could be really neat. |
f26c795
to
88a335c
Compare
88a335c
to
d3762bc
Compare
The purple is definitely an improvement over the red. What is the distinction between the double-thin lines and the strong dashed lines? |
Dashed line, feet touch the ground. Two parallel lines, you're five stories up. |
Note in the Courchevel example above, there are two drag lifts (dashed lines) that pass under road bridges. Ideally, |
paint: { | ||
"line-color": Color.backgroundFill, | ||
"line-width": casingLineWidth, | ||
"line-gap-width": casingLineGapWidth, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The legend doesn’t correctly implement line-gap-width
, making this legend entry look misleading: #770.
Of the three colors shown in screenshots so far, the pink looks best to my eyes. I also find the endpoint dots Quincy suggested help set the aerialways apart from other liner features. Something like that seems like a good idea. The low zoom screenshots with a single line rather than a double were looking more chairlift-like to me. I wasn't sure why until I went looking at ski resort trail maps and remembered that they generally just use a single line. Maybe a single line would work well at higher zoom levels too? Or maybe there are other types of maps that commonly show aerial lifts as double lines? |
There seems to be some conflicting opinions on the color. I do like the purple, though I suspect whatever color we use here is likely to become the public transit color. Purple would make train stations and bus stops hard to find within airports.
Aerialways always start and end at stations, which are POIs that I intend to implement separately. #692
Cables are typically 15-20 feet apart in real life. There aren't many high-zoom examples of aerialways on maps, but at a zoom level where indoor features could potentially show up, it looks clunky to me if this gap isn't present. I could probably adjust the threshold to a higher zoom level, though. |
Regarding the color, I think the bubblegum pink or the red has a certain flair that fits with the Pop Art labeling. Makes it feel sportier. But a more muted purple is fine too. The important thing is that no one would mistake it for a kind of road,1 and I think purple accomplishes that. Footnotes
|
By the way, the screenshot in #755 (comment) seems to be showing an aerialway name of the format |
I haven't seen that outside of Bolivia. I agree that the termini shouldn't be in the name, but that is a tagging issue for local communities to solve. I wouldn't bother with writing extra code to hide names that conform to suspicious PTv2 tagging. |
While red would be great on a ski-specific map, I think having purple be the general-purpose transit color makes sense as visual language. And the doubling at high zoom is a nice touch. The one thing that stood out to me is that the font descents obscure the lines a bit. Are we okay with that or should the text be offset a bit more? |
One last change: magenta. Because if we're gonna need to repurpose this color for public transit, it can't be the airport purple, since airports aren't necessarily passenger transport facilities. Also, I'm gay for transit 🏳️🌈🚡 I think this is as good as it's going to get for now. Tail work:
|
Regarding:
Can you summarize what's different between aerialway rendering and road rendering that would cause this bug to appear in one case and not the other? |
|
Here’s one of those test areas above: Setting Essentially, we’re expecting One workaround would be to set With a wider knockout, it could do a good job of emphasizing that there are two parallel lines as opposed to a casing. |
Moreover, I think this GL JS behavior is pretty reasonable. For example, the boundary edge labels in #52 shouldn’t flip across the line based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think it's time to get this change in the map!
Fixes #500
Breckenridge, Colorado, US:
La Paz/El Alto, Bolivia:
Aletsch Arena, Valais/Wallis, Switzerland:
Medellín, Colombia: