-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Costa Rica shields #458
Draft
claysmalley
wants to merge
13
commits into
main
Choose a base branch
from
shields-costa-rica
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
dd6ba6d
Add Costa Rica shields
claysmalley 31da714
Merge branch 'main' into shields-costa-rica
claysmalley 87217e8
Merge branch 'main' into shields-costa-rica
claysmalley 5f0b548
Refactor and rename common shield designs
claysmalley d79a56f
Merge branch 'main' into shields-costa-rica
claysmalley 3bc1061
Merge branch 'main' into shields-costa-rica
claysmalley 452b535
Merge branch 'main' into shields-costa-rica
claysmalley 77fc76d
Merge branch 'main' into shields-costa-rica
claysmalley 1999a9e
Merge branch 'main' into shields-costa-rica
claysmalley a6b6702
Merge branch 'main' into shields-costa-rica
ZeLonewolf feb60d6
Merge branch 'main' into shields-costa-rica
claysmalley d7f8118
Merge branch 'main' into shields-costa-rica
ZeLonewolf 62e2e44
Merge branch 'main' into shields-costa-rica
ZeLonewolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
network=CR:national
is being tagged on every route in the National Road Network, making no distinctions between primary, secondary, and tertiary routes, even though all three classes have different shields. This is similar to the situation in #455 (comment).network=CR:national
está aplicado en cada ruta de la Red Vial Nacional, sin distinción entre las rutas primarias, secundarias, y terciarias, aunque las tres clasificaciones tienen los señales diferentes. Es similar con la situación en #455 (comment).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like a showstopper, right? Don't we have a similar situation in a country in Europe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think so. We must be able to determine shield appearance from
network=*
, and three different route shields are all assignednetwork=CR:national
. This would need to be fixed before we can support Costa Rican shields.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked the talk-cr mailing list for help.