Add several indigenous American languages to language picker #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Jan 5, 2025
src/js/language_label.js
Outdated
| // included as a fallback, in case CLDR is missing data on language names. | ||
|
|
||
| // Eskaleut | ||
| { id: "ale", name: "Aleut" }, |
There was a problem hiding this comment.
This is fine as a start, but maybe we could try to source the names dynamically from Wikidata, like we do for route networks in the legend. That would allow us to support more interface languages than just English, which seems appropriate for a feature focused on multilingualism.
There was a problem hiding this comment.
I'm in favor of sourcing language labels from Wikidata, though I'm not experienced with async Wikidata queries. I'll make a separate issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to the language picker 207 languages indigenous to the so-called United States. Since Unicode CLDR is missing language names for most of them, I've included the English name of each as a fallback.
Note that many of these languages currently have no geographic labels on OSM or Wikidata, and the map will just fall back to English. By surfacing these languages in the picker, I hope to encourage mappers to fill in the gaps.